Project-Name-Here/checkmk-minecraft
3
0
Fork 1
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

graphing/graph_minecraft.py edited #2

Open
Tiippex wants to merge 1 commits from Tiippex/checkmk-minecraft:tiippex-patch-1 into master
pull from: Tiippex/checkmk-minecraft:tiippex-patch-1
merge into: Project-Name-Here:master
Conversation 1 Commits 1 Files Changed 1 +38 -29
Tiippex commented 2026-07-12 02:40:21 +02:00
First-time contributor
Copy Link

Fixes #1

Fixes #1
Tiippex added 1 commit 2026-07-12 02:40:21 +02:00
graphing/graph_minecraft.py aktualisiert 25007554ca 
Fixes #1
spacelord requested review from spacelord 2026-07-12 15:00:56 +02:00
spacelord requested changes 2026-07-12 15:47:23 +02:00
spacelord left a comment
Owner
Copy Link

Thank you!

The migration generally looks good for Checkmk 2.5.0. Before merging, I would like you to check the following:

  • Please consider using the documented public import path:

    from cmk.graphing.v1 import Title
from cmk.graphing.v1.graphs import Graph

    This import layout is used in the official Checkmk 2.5 graphing examples.

  • Verify that all five graphs are displayed correctly: TPS, Tick Time, Players, Ping, and Protocol Version.

  • Please preserve the previous ms units and the custom Online and Max labels by adding the corresponding metric definitions for the new graphing API.

  • Please also preserve the TPS threshold visualization. The existing TPS thresholds can be added as fixed constants directly to the graph definition. The new API provides Constant objects, which can be used as simple lines in the graph.

Useful documentation:
https://docs.checkmk.com/latest/en/devel_check_plugins.html#metrics_advanced
https://docs.checkmk.com/plugin-api/master/cmk.graphing/v1.metrics.html
https://docs.checkmk.com/plugin-api/master/cmk.graphing/v1.graphs.html

Thank you! The migration generally looks good for Checkmk 2.5.0. Before merging, I would like you to check the following: * Please consider using the documented public import path: ```python from cmk.graphing.v1 import Title from cmk.graphing.v1.graphs import Graph ``` This import layout is used in the official Checkmk 2.5 graphing examples. * Verify that all five graphs are displayed correctly: TPS, Tick Time, Players, Ping, and Protocol Version. * Please preserve the previous `ms` units and the custom `Online` and `Max` labels by adding the corresponding metric definitions for the new graphing API. * Please also preserve the TPS threshold visualization. The existing TPS thresholds can be added as fixed constants directly to the graph definition. The new API provides `Constant` objects, which can be used as simple lines in the graph. --- Useful documentation: https://docs.checkmk.com/latest/en/devel_check_plugins.html#metrics_advanced https://docs.checkmk.com/plugin-api/master/cmk.graphing/v1.metrics.html https://docs.checkmk.com/plugin-api/master/cmk.graphing/v1.graphs.html
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u tiippex-patch-1:Tiippex-tiippex-patch-1
git checkout Tiippex-tiippex-patch-1
Sign in to join this conversation.
Reviewers
No Reviewers
spacelord
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
grey Jira spacelord
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Project-Name-Here/checkmk-minecraft#2
Delete Branch "Tiippex/checkmk-minecraft:tiippex-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?